fix(story): add table design #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
eunjae-lee
commented
Dec 11, 2023
| }>(); | ||
| </script> | ||
|
|
||
| <template> |
There was a problem hiding this comment.
Sorry for the big diff. It was inevitable as I split stuff into smaller chunks. However, the majority of the code is the same.
There was a problem hiding this comment.
Love to see some code splitting <3
BibiSebi
reviewed
Dec 11, 2023
|
|
||
| const lastUpdate = computed(() => { | ||
| const timestamp = props.story.updated_at || props.story.created_at; | ||
| const [date, time] = timestamp.split('T'); |
There was a problem hiding this comment.
I was trying to find out how nuxt handles the formatting of dates and https://nuxt.com/modules/date-fns there is this, but for now a new dependency might be too much so its fine to leave it as is.
There was a problem hiding this comment.
ah yeah, date-fns is definitely a great choice for date formatting as soon as we need to really format it :)
Merge activity
|
eunjae-lee
force-pushed
the
fix/loader
branch
from
729b89a
to
27ab962
Compare
eunjae-lee
force-pushed
the
fix/add-table-design
branch
from
cbb55df
to
cac6d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds table design to the story list, and refactors into smaller components.
Screenshot.2023-12-11.at.17.27.25.mp4
How to test? (optional)