Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(story): add header design #15

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(story): add header design #15

merged 1 commit into from
Dec 12, 2023

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Dec 8, 2023

What?

This PR adds header design.

Screenshot.2023-12-08.at.11.05.17.mp4

I added a functionality to attach right action buttons, which is hidden at the moment.

"autoprefixer": "10.4.16",
"daisyui": "^4.4.19",
"h3": "^1.8.2",
"nuxt": "^3.8.0",
"nuxt-lucide-icons": "1.0.3",
Copy link
Contributor Author

@eunjae-lee eunjae-lee Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucide is an icon library: https://lucide.dev/ (supports many frameworks)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we will need to use the icons from blok.ink (maybe just exported as svg). Does it make sense the use lucid icons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BibiSebi hmm I didn't think of the aspect. Could you give me an example on what kind of blok.ink icons we need to use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I didn't even know there are icon sets within blok.ink 🤯

https://blok.ink/?path=/docs/basic-sbicon--documentation#storyblok-icons

still not sure what to do about it, though 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I just highlighted some icons we will need.
We could extract those as SVG and use them directly inside our code? that is an option and then might not need nuxt-lucid-icons. We might even want to have a small internal package with all these icons as svg so that we can reuse them. WDYT?

Screenshot 2023-12-11 at 18 15 50

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. If it's okay to use slightly different looking icons, I'd prefer to use an icon library instead of keeping the icons directly within the repo, especially when dealing with both Vue and React. It's because it's a bit of pain to deal with svgs in general. For example, in vue, you'd want to have an icon file like:

// IconMagnifier.vue

<template>
  <svg ....>...</svg>
</template>

If you want to apply a color or size to the svg, then you need to receive props like:

// IconMagnifier.vue

<script setup>
defineProps(['color', 'size'])
</script>

<template>
  <svg style={{ color, fontSize: size }} ....>...</svg>
</template>

(I mean something better than that)

and we need to recreate the same thing for React component because of the different syntax.

On the other hand, icon libraries like lucide provide components for different frameworks including the basic props like above. And you get to import the only icons you're using, not the whole set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we can go with the icons library :). I thought maybe daisy UI cold help us with the coloring and size without the need to pass props necessarily

@eunjae-lee
Copy link
Contributor Author

eunjae-lee commented Dec 8, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@eunjae-lee
Copy link
Contributor Author

eunjae-lee commented Dec 12, 2023

Merge activity

@eunjae-lee eunjae-lee merged commit 096acc3 into main Dec 12, 2023
2 checks passed
@eunjae-lee eunjae-lee deleted the chore/add-header branch December 12, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants