Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gameplay/Game modifier/Perfect #9792

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

heipizhu4
Copy link
Contributor

@heipizhu4 heipizhu4 commented Jul 31, 2023

Just discovered this 'feature' and decided to add this to the wiki
4948aec655f119ac

Self-check

Copy link
Contributor

@agatemosu agatemosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 32 and 29 also change it to "OK"/"MEH"/"GREAT", and replace score with judgement in 29

wiki/Gameplay/Game_modifier/Perfect/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Perfect/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Perfect/en.md Outdated Show resolved Hide resolved
@TicClick TicClick changed the title Update Perfect Update Gameplay/Game modifier/Perfect Jul 31, 2023
Copy link
Contributor

@agatemosu agatemosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing line 29 to:

The **Perfect** mod is a [game modifier](/wiki/Gameplay/Game_modifier) that aims to aid players who are going for an SS grade by automatically failing and retrying [beatmaps](/wiki/Beatmap) if the player misses a note or obtains any judgement on a [hit object](/wiki/Gameplay/Hit_object) other than GREAT.

And it remains to change line 34

@heipizhu4
Copy link
Contributor Author

I suggest changing line 29 to:

The **Perfect** mod is a [game modifier](/wiki/Gameplay/Game_modifier) that aims to aid players who are going for an SS grade by automatically failing and retrying [beatmaps](/wiki/Beatmap) if the player misses a note or obtains any judgement on a [hit object](/wiki/Gameplay/Hit_object) other than GREAT.

And it remains to change line 34

Fixed.

wiki/Gameplay/Game_modifier/Perfect/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Perfect/zh.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Perfect/zh.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Perfect/zh.md Outdated Show resolved Hide resolved
@TicClick TicClick added the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Aug 2, 2023
@TicClick TicClick enabled auto-merge August 2, 2023 17:12
@TicClick TicClick removed the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Aug 2, 2023
@TicClick TicClick merged commit da538ce into ppy:master Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants