Rewrite judgement articles

[Walavouchey]

part of #8189

stuff to check

• Opinions on whether we want to use the new judgement names throughout articles. I thought it seemed ok, even though technically they only appear in lazer.
  • Blocked on finalised judgement names? another day
• The mania Perfect, Meh, and Miss windows differ from the OD article as i've taken all of them from lazer. Will need to confirm whether this is an actual gameplay difference between lazer and stable.
  • Turns out the OD article was just wrong and put the Miss window in the place of the Meh window (and left out miss windows)
• Confirm hit window/hit error rounding shenanigans
  • The hit windows are truncated after accounting for OD, while the hit error uses rounded time derived from the audio engine.
  • DT and HT make the clock tick faster and slower respectively, which scales the hit error and hit windows, which may affect how much the hit windows can vary. Haven't thought it through thoroughly.
• Confirm spinner spin requirements

remarks

• The mania hold note table was created by empirical testing (I have no idea what the logic there is, but it's different from lazer I believe)
  • Potentially redo table due to 1.5x-as-lenient release windows
    • redone using stable source
• no idea what to do about the catch article, it doesn't seem to have the concept of "judgements" in the same way anyway

future effort

• separate article for judgement names in other rhythm games
• fix mentions of judgements across the wiki
• move slightly out-of-scope stuff like score and accuracy-related information out of the judgement articles
• fill index page with a more general gameplay-related description about judgements (judgement line, approach circle)

[TicClick]

might be extra material for respective hit object articles

[TicClick]

random suggestion: mention o!m's judgement line maybe? or do you think it deserves its own article, like osu!'s approach circle?

[Walavouchey]

random suggestion: mention o!m's judgement line maybe? or do you think it deserves its own article, like osu!'s approach circle?

hmm i have an idea on how this should work but i won't have time to address it for at least two weeks

i.e. not in this pr

[Walavouchey]

pinging @peppy / @smoogipoo for the "stuff to check" checklist

"addressed"

[peppy]

Opinions on whether we want to use the new judgement names throughout articles. I thought it seemed ok, even though technically they only appear in lazer.

We are all in agreement on doing this. That said, we're also considering renaming the internal terms to avoid upsetting a portion of the community, so it would be worth waiting for that to happen and be finalised (likely will be done this month).

Previous: Miss < Meh < OK < Good < Great < Perfect
Proposed: Miss < Bad < OK < Good < Great < MAX

The mania Perfect, Meh, and Miss windows differ from the OD article as i've taken all of them from lazer. Will need to confirm whether this is an actual gameplay difference between lazer and stable.

I've given you access to the stable reference code so you can hopefully check this. Let me know if you can't figure it out and I'll go look for you.

Confirm hit window/hit error rounding shenanigans

I presume this is the off-by-0.5ms thing? I think there's still an open discussion on that potentially being different in lazer, so would be best to track that there. See ppy/osu#11311.

Confirm spinner spin requirements

Ha ha. I'd highly recommend not attempting to figure this out from the stable code base. I think there's a group of community members that figured out a formula for this, but I haven't confirmed its accuracy yet. I'll try and find a link to this, but you may find it faster than I can (was in a reddit thread related to spinning).

[Walavouchey]

I think there's a group of community members that figured out a formula for this

I do know about this as i've learned from a certain reddit post about spinners. I have considered contacting them, yes

[Walavouchey]

would it be good to add internal reference comments, linking to the stable reference repo?

[Walavouchey]

after checking with stable source apparently there were some random bits of information that were inconsistent or not mentioned

• the formula for the minimum required spins per second from https://osu.ppy.sh/wiki/en/Beatmap/Overall_difficulty#sliders-and-spinners is the exact formula used in the code, except that it deals in half rotations which has been adjusted here
• this random +0.5 relates to the "All spinners required half of a spin more to complete." trivia in the history section. all spinners really were nerfed by 1/2 rotation for some ungodly reason (before it would've been +1)
  • due to this the "minimum spins per second" formula listed here is actually slightly less than what you'd need (by 0.5 / length in seconds so not much in actuality)
• the "clear" text for spinners actually appears half of a rotation before you'd get a GREAT, and half of a rotation after you'd get an OK (if you stopped immediately you'd get an OK)
• the "One spin less than the required number" for the OK requirement was in terms of full spins, so that part didn't need changing

I'd highly recommend not attempting to figure this out from the stable code base.

well the judgement part wasn't so bad to investigate, but figuring out maximum score possible (involving maximum possible rotations) is way more involved. there is a desmos calculator for this though and it's true that it would be better to empirically test that against stable (but that info would be put somewhere like Gameplay/Score or Gameplay/Hit_object/Spinner)

[TicClick]

would it be good to add internal reference comments, linking to the stable reference repo?

I think so. would use inline HTML comments, given that the repository is virtually inaccessible by anyone other than a handful of people (if it was more widespread, but still vastly limited, that would've been worth putting in the footnotes)

[Walavouchey]

• Blocked on finalised judgement names?

at this point i don't think this pr should be blocked on something silly like this. i'm more inclined to just go with these changes as is and use the current judgement names for now, so i can move on with the rest of the planned changes.