Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diag layer refactoring spinoffs #327

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Diag layer refactoring spinoffs #327

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
367ae69
somersaultecu: internalize the COMPARAM-SPEC
andlaus Aug 2, 2024
9758bca
somersaultecu: introduce a protocol diagnostic layer
andlaus Aug 2, 2024
ed4c2d1
`DiagLayer`: rename the `.diag_comm` attribute to `.diag_comm_raw`
andlaus Aug 2, 2024
a32f0ea
`DiagLayer`: rename `.comparams` to `.comparam_refs`
andlaus Aug 2, 2024
2253d6b
ComparamSpec: the ID attribute is mandatory
andlaus Aug 2, 2024
a78e21e
ServiceBinner: actually print the service IDs in hexadecimal in `repr()`
andlaus Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions odxtools/comparamspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ def from_et(et_element: ElementTree.Element, doc_frags: List[OdxDocFragment]) ->

def _build_odxlinks(self) -> Dict[OdxLinkId, Any]:
odxlinks: Dict[OdxLinkId, Any] = {}
if self.odx_id is not None:
odxlinks[self.odx_id] = self
odxlinks[self.odx_id] = self
kayoub5 marked this conversation as resolved.
Show resolved Hide resolved

if self.admin_data is not None:
odxlinks.update(self.admin_data._build_odxlinks())
Expand Down