Diag layer refactoring spinoffs #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
the convention is that if a list can contain more than one type of object, it gets a `_raw` suffix plus a separate property for the processed data. In this case `.diag_comm_raw` may contain a `OdxLinkRef`s to diagnostic communication objects or the diagnostic communication objects themselfs. since diagnostic communication objects may be either `DiagService` or `SingleEcuJob`, we now provide the diagnostic communication objects with the resolved references via `.diag_comms` and further stratify those into `.diag_services` and `.single_ecu_jobs`. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
i.e., no need to check if it is `None`. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
kayoub5
reviewed
Aug 2, 2024
kayoub5
reviewed
Aug 2, 2024
kayoub5
reviewed
Aug 2, 2024
even though we prefixed these numbers with `0x`, they were actually printed as decimals... Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
kayoub5
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains most (i.e., all I found) of the changes of #326 which are not or only tangentially related to refactoring the
DiagLayerclass into a class hierarchy corresponding to the ODX specification.Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information