Added jquery injection
#127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you really want to use `jquery-browserify` (useless IMO), just map `jquery` to `jquery-browserify` using Browserify's `require`. Build tools should not interfere with code.
arschmitz
added a commit
to arschmitz/jquery-mousewheel
that referenced
this pull request
May 22, 2015
arschmitz
added a commit
to arschmitz/jquery-mousewheel
that referenced
this pull request
May 22, 2015
arschmitz
added a commit
to arschmitz/jquery-mousewheel
that referenced
this pull request
May 22, 2015
arschmitz
added a commit
to arschmitz/jquery-mousewheel
that referenced
this pull request
Jul 1, 2015
|
I was about to make this PR myself :) Love this plugin! If you merge this PR to improve the UMD wrapper, it would make it a tad cleaner to use in a CommonJS environment |
|
Not sure about that... In jQuery Core if you use Browserify Wouldn't a similar approach work here? |
|
Bumping this! |
This was referenced Sep 27, 2021
Open
|
My comment from #127 (comment) still stands; in my opinion, it'd be better to duplicate the jQuery wrapper. @dmethvin what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you really want to use
jquery-browserify,just map
jquerytojquery-browserifyusing Browserify'srequire.Build tools should not interfere with code.