Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-passive event listeners issue and add a updated version number #215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

summercms
Copy link

Relates to (my old account) issue found here: #202

Have tested this and works fine.

@ghost
Copy link

ghost commented Sep 27, 2021

@mgol another one to review after #127

@ghost ghost mentioned this pull request Sep 27, 2021
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is essentially a noop but it doesn't work in IE which has no support for passive listeners. The upstream jQuery also doesn't use a pattern like this so I'm not in favor.

@dmethvin what do you think?

@ghost
Copy link

ghost commented Sep 27, 2021

Could it be put behind a compatibility layer for non-IE?

@mgol
Copy link
Member

mgol commented Sep 27, 2021

Yes, it could, but it'd still be adding lots of bytes just to silence browser warnings without any actual change in behavior. If we were doing that for jQuery as well it'd make sense but I'm not sure about doing it just in this plugin, diverging from the upstream.

@ghost
Copy link

ghost commented Sep 27, 2021

Okay, so the ideal thing to do is icebox this and have passive event listeners adopted in JQ core?

@mgol
Copy link
Member

mgol commented Sep 27, 2021 via email

@summercms
Copy link
Author

summercms commented Apr 20, 2022

@mgol Internet Explorer 11 desktop application will be retired and go out of support on June 15, 2022. Therefore this repo shouldn't continue to support ie11 after end of life date reached.

Link: https://blogs.windows.com/windowsexperience/2021/05/19/the-future-of-internet-explorer-on-windows-10-is-in-microsoft-edge/

@mgol
Copy link
Member

mgol commented Apr 20, 2022

This project will most likely keep following the browser support policy of jQuery and there are no plans to drop IE 11 support there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants