Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): Added hydration-overlay integration for nextjs projects #343

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

Shubhdeep12
Copy link
Collaborator

@Shubhdeep12 Shubhdeep12 commented Jan 30, 2024

Before opening this PR:

To test the integration please follow these steps:

  1. This integration needs a nextjs app.
  2. Install and setup the hydration-overlay package - https://github.com/BuilderIO/hydration-overlay
  3. Since the integration for spotlight is not yet integrated - use this branch to test - https://github.com/Shubhdeep12/hydration-overlay/tree/feat/spotlight-integration
  4. Manipulate <HydrationOverlay> to <HydrationOverlay integrations={{ spotlight: true }}>
  5. And while initiating Spotlight add a hydrationError() integration

Demo

Screencast.from.30-01-24.08.56.11.PM.IST.webm

Note: Spotlight integration in hydration-overlay can be tracked here

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 0:40am

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0b5d49) 28.91% compared to head (7560855) 28.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   28.91%   28.91%           
=======================================
  Files          60       60           
  Lines        4088     4088           
  Branches       72       72           
=======================================
  Hits         1182     1182           
  Misses       2906     2906           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HazAT HazAT merged commit 8983a8f into main Feb 1, 2024
9 checks passed
@HazAT HazAT deleted the feat/hydration-verlay-integration branch February 1, 2024 14:54
samijaber pushed a commit to BuilderIO/hydration-overlay that referenced this pull request Jul 30, 2024
Feature Addition: Spotlight Integration in Hydration-Overlay

This pull request introduces an integration of Spotlight into the
hydration-overlay module.

Key Highlights:
- Addressed all necessary conditions outlined in the discussion
[here](#40 (comment)).
- Note: Current integration and tests may not function as expected due
to pending integration support in Spotlight. The implementation is
primed for action once the necessary changes are merged.

Next Steps:
- Track the progress of Hydration-overlay integration in Spotlight
[here](getsentry/spotlight#343).
- Upon completion of Spotlight integration, a simple version update for
the Spotlight package in this repository is all that's needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants