Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spotlight integration with hydration-overlay #41

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

Shubhdeep12
Copy link
Contributor

Feature Addition: Spotlight Integration in Hydration-Overlay

This pull request introduces an integration of Spotlight into the hydration-overlay module.

Key Highlights:

  • Addressed all necessary conditions outlined in the discussion here.
  • Note: Current integration and tests may not function as expected due to pending integration support in Spotlight. The implementation is primed for action once the necessary changes are merged.

Next Steps:

  • Track the progress of Hydration-overlay integration in Spotlight here.
  • Upon completion of Spotlight integration, a simple version update for the Spotlight package in this repository is all that's needed.

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: f199813

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@builder.io/react-hydration-overlay Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Shubhdeep12
Copy link
Contributor Author

Hi @samijaber, we are done here.
we published a new version in spotlight to support hydration-overlay.
Added a test case also for nextjs app.

Please review.

Thanks.

btw, I found a issue while setting up webpack in nextjs with hydation-overlay but that will not hamper anything here.
I'll open it seperately.

@Shubhdeep12
Copy link
Contributor Author

Shubhdeep12 commented May 17, 2024

Hi @samijaber just bumping here as a reminder for this PR.
Thanks

@steve8708 steve8708 requested a review from samijaber July 26, 2024 19:34
Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Shubhdeep12! And thanks for your patience until we got around to reviewing this 🙏🏽

@samijaber samijaber merged commit 1075a84 into BuilderIO:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants