Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some aspects of the control tre/plugin infrastructure #827

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    eb4f965 View commit details
    Browse the repository at this point in the history
  2. Use siz_t for all kernel IDs.

    - User-registered kernels are contained in the `ukr_t`, `bszid_t`, and `ukr_pref_t` enums, so prefer `siz_t` for all functions taking kernel ID parameters.
    - However, because enum constants are by default `int` (or even smaller), while `siz_t` will typically be `long long unsigned int`, this causes problems with variadic arguments in `bli_cntx_set_ukrs` and friends (predefined vs. user-registered kernel IDs will be incompatible types).
    - Solution: define `BLIS_VA_END` explicitly as `(siz_t)-1` and add an enum entry equal to `BLIS_VA_END` (=`0xf...f`) to each affected enum in order to force the underlying enum type to be as wide as `siz_t`.
    devinamatthews committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9abb002 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Have bli_gemm_cntl_init indicate transpose.

    Return a bool which is true iff the operation was transposed (C = A B -> C^T = B^T A^T).
    devinamatthews committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    33cdd62 View commit details
    Browse the repository at this point in the history
  2. Move BLIS_VA_END.

    devinamatthews committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    03d23ac View commit details
    Browse the repository at this point in the history