Fix some aspects of the control tre/plugin infrastructure #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- User-registered kernels are contained in the `ukr_t`, `bszid_t`, and `ukr_pref_t` enums, so prefer `siz_t` for all functions taking kernel ID parameters. - However, because enum constants are by default `int` (or even smaller), while `siz_t` will typically be `long long unsigned int`, this causes problems with variadic arguments in `bli_cntx_set_ukrs` and friends (predefined vs. user-registered kernel IDs will be incompatible types). - Solution: define `BLIS_VA_END` explicitly as `(siz_t)-1` and add an enum entry equal to `BLIS_VA_END` (=`0xf...f`) to each affected enum in order to force the underlying enum type to be as wide as `siz_t`.
Return a bool which is true iff the operation was transposed (C = A B -> C^T = B^T A^T).
|
I'll fix the build shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PNAMEmacro to generate symbol names in plugins. This makes it much easier for uses to see what names their symbols will have (and to change them if desired).siz_trather thanukr_tfor anything dealing with kernel IDs (and similar for blocksizes and kernel preferences). Because users can now register new kernels, the values of the IDs for their custom kernels are no longer enumerated inukr_t, which causes type conversion problems. This requires also being careful about the type ofBLIS_VA_ENDand forcing existing enumerations likeukr_tto be represented using integers of the same width assiz_t.gemmcontrol tree initialization function to indicate whether or not the operation as a whole was transposed. This is needed if users have to treat the initialAandBdifferently in the control tree, for example in a tensor times matrix operation (if transposed to matrix times tensor, we need to know which "matrix" object is now the tensor).