Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of ExercismExerciseGenerator #586

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

Bajger
Copy link
Contributor

@Bajger Bajger commented Sep 13, 2023

Generation of test class, its cases from problem specifications.

  • added pragmas with test case metadata
  • otherwise result should be same as original implementation

…est cases from problem specifications.

- added pragmas with test case metadata
- otherwise result should be same as original implementation
@Bajger Bajger self-assigned this Sep 13, 2023
@Bajger Bajger linked an issue Sep 13, 2023 that may be closed by this pull request
@Bajger
Copy link
Contributor Author

Bajger commented Sep 19, 2023

@glennj : I've refactored exercise test generator that is used when building new exercise from canonical description. Result of this generator is Test class in Pharo that contains test case methods and setup (placed in WIP package). Thanks for reviewing this!

@Bajger Bajger added source generation Concerning generation of exercise source code and READMEs x:action/improve Improve existing functionality/content x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/generator Work on Exercise generators x:size/medium Medium amount of work labels Sep 19, 2023
@Bajger
Copy link
Contributor Author

Bajger commented Oct 2, 2023

@glennj @ErikSchierboom Thanks for approving this! Changes should be save (not used in usual user production code, only when generating new exercise) to use.

Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it!

@Bajger Bajger merged commit be8cba3 into exercism:main Oct 3, 2023
4 checks passed
@Bajger Bajger deleted the 585-Refactor-Exercise-test-generator branch October 3, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source generation Concerning generation of exercise source code and READMEs x:action/improve Improve existing functionality/content x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/generator Work on Exercise generators x:size/medium Medium amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Exercise test generator
3 participants