Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint issues in variations.js #26

Closed
wants to merge 20 commits into from
Closed

eslint issues in variations.js #26

wants to merge 20 commits into from

Commits on Jul 4, 2024

  1. @purejerome says to put this in eslint

    @hcientist
    hcientist committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b632928 View commit details
    Browse the repository at this point in the history

  2. let's configure the project to use the eslint for the formatter and t… 

    …o format all the time. thanks @purejerome
    @hcientist
    hcientist committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    550f369 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. update prettier version, require eslint plugin

    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e766dbc View commit details
    Browse the repository at this point in the history

  2. test standardizing format on a single file: api.js 

    tested with
npx eslint --config .eslintrc.json api.js

seems like I only needed to do

npx eslint api.js
    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    aa43048 View commit details
    Browse the repository at this point in the history

  3. eslint and prettier disagree about indentation, let prettier win bc w… 

    …ho cares
    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5b49450 View commit details
    Browse the repository at this point in the history

  4. with these changes, top-level .js files all pass eslint with no warni… 

    …ngs or errors
    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7c6c307 View commit details
    Browse the repository at this point in the history

  5. with these changes, top-level pages pass linter

    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    cad351e View commit details
    Browse the repository at this point in the history

  6. whoops this extension cannot format jsx.

    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    eadbf17 View commit details
    Browse the repository at this point in the history

  7. with these changes, all pages pass linter

    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c05ebeb View commit details
    Browse the repository at this point in the history

  8. don't care about this rule

    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    2323b2d View commit details
    Browse the repository at this point in the history

  9. most files are formatted. many linting errors remain, i'm inclined to… 

    … fix most of them...
    @hcientist
    hcientist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b110734 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix eslint problems in variations.js

    @mfwolffe
    mfwolffe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0f95f95 View commit details
    Browse the repository at this point in the history

  2. flatjs and performjs eslint

    @mfwolffe
    mfwolffe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    61eb0b6 View commit details
    Browse the repository at this point in the history

  3. recentSubmissionjs; verify camelcase rename does not break

    @mfwolffe
    mfwolffe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4ad2f89 View commit details
    Browse the repository at this point in the history

  4. piece picker - switch to useCallback() to satisfy linter

    @mfwolffe
    mfwolffe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ba5fe80 View commit details
    Browse the repository at this point in the history

  5. imports out of order

    @mfwolffe
    mfwolffe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0a4c0a8 View commit details
    Browse the repository at this point in the history

  6. theoreticaljs eslint; preferred approach for array indices in div keys?

    @mfwolffe
    mfwolffe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b4d3344 View commit details
    Browse the repository at this point in the history

  7. exploratoryjs linter; mostly useCallbacks

    @mfwolffe
    mfwolffe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    aca0013 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. dropped nested ternary since it was overcomplicated anyway, these are… 

    … now inteneded to be mutually exclusive, but we drop the guarantee, risk is acceptable.
    @hcientist
    hcientist committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    475a9d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge pull request #2 from hcientist/standardize_format 

    Trying to ofer these minor changes to your PR...
    @mfwolffe
    mfwolffe committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    30834f8 View commit details
    Browse the repository at this point in the history