eslint issues in variations.js #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o format all the time. thanks @purejerome
tested with npx eslint --config .eslintrc.json api.js seems like I only needed to do npx eslint api.js
… fix most of them...
|
@hcientist I verified variation algorithms do not break from changes; I think particular attention should be given to potential side effects from changes to |
… now inteneded to be mutually exclusive, but we drop the guarantee, risk is acceptable.
Trying to ofer these minor changes to your PR...
|
I htink we had you re-create this against my fork's corresponding branch to make it easier to review? if not, let's re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
down to 8 total from 59
I believe @hcientist said jerome would take care of
recorder.jsin which case it would only be 1 eslint error and 1 warning left@hcientist how would you prefer to proceed with the remaining error in
theoretical.js(array indices in element keys), and the warning ininstructions.js(flagged from usingdangerouslySetInnerHTML)