Updated Old Bailey Online translator #3357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed function
linter issues. one remaining so this will presumably still fail but I don't understand why it's a problem.
maybe probably this time.
AbeJellinek
requested changes
Sep 3, 2024
|
Thank you! I can't test because the site errors for me right now, but the changes look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update to the Old Bailey Online website broke the translator. This is a rewrite using the site API (it's no longer possible to scrape the site directly). It's the first time I've tried doing one like this; I based it on the translator for the US national archives and it seems to be working but it's quite possible I've made some appalling mistakes.