Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject an instantiated persistence handler. #53

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mogilvie
Copy link

Hi, the current method of creating a custom persistence handler doest allow the developer access to the constructor or setter methods.

Instead, consider injecting a custom persistence handler. I've done this by adding the custom handler to the config array at run time.

Although better yet would be a setter method.

@dansionGit
Copy link

dansionGit commented Sep 7, 2020

Hi,

This is exactly the feature I was searching for but couldn't find in the current code.
This would allow properly integrating the PHP-SDK into frameworks with Dependency Injection / their own ORM.
It's a simple addition to this codebase which would make integrating this library into our own projects so much easier and cleaner.

I hope this feature is merged into this library soon!

@phil-schreiber
Copy link

Is there any way we can support to get this merged?

@mogilvie
Copy link
Author

Do I need to do anything else here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants