Append g:zig_std_dir to &path #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the local value of path means that if the user has not set a local value for path, the value of 'path' will just be 'g:zig_std_dir'. By using '&path' the current value of 'path' is used (i.e. if no local value is set the global one is used). For example, this means that if 'path' is at its default value of '.,/usr/include/,,' (which is not local) before loading the ftplugin, before this change the default value of path would be completely replaced, making gf not find files files relative to the current file or directtory. With this change, gf will find imported files relative to the current file and directory by default. Appending 'g:zig_std_dir' rather than prepending means that zig files with the same name as ones in the standard library should be resolved to the one the project one is working on rather than the one in the standard library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour of the path option setting seems unintuitive to me: it ignores the global value of the path option, so any globally desired value of path (like the current directory/file) must be copied into the local local value in order files to be found anywhere outside the standard library. In particular this makes the default behaviour (i.e. if the user does not explicitly set a local value for
pathbefore the ftplugin is sourced) to not resolve files relative to the current file or directory (the default (global) value ofpathdoes this). This change uses&pathinstead of&l:pathto fix this, making the default behaviour work as (I think should be) expected.In addition, this change appends rather than prepends the standard library path - if a zig file does
@import("builtin.zig")and there is a filebuiltin.zigin the same directory, then the file being imported is (barring some extreme use ofmain-pkg-path) that one, not the one in the standard library, so appending will make gf resolve it correctly with the defaultpathoption.