Fixing indentation on empty brackets with trailing comma/colon (issue #42) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not fully sure if this fixes, it. Still experimenting.
yohannd1
commented
Jun 13, 2021
| if prevLine =~ '\v^\s*},$' | ||
| if currentLine =~ '\v^\s*};$' || currentLine =~ '\v^\s*}$' | ||
| if prevLine =~ '\v^\s*}\s*[,;]\s*$' | ||
| if currentLine =~ '\v^\s*}\s*[,;]?\s*$' | ||
| return indent(prevLineNum) - 4 | ||
| endif | ||
| return indent(prevLineNum-1) - 4 |
There was a problem hiding this comment.
By the way - I haven't modified this specific line (l. 56) but I'm curious: wouldn't it be better if it were indent(prevLineNum)? As far as I understood it gets the indentation inside the previous block and deindents it by one level, which I believe should result in the same as indent(PrevLineNum).
|
before I hit enter after I hit enter With the changes in this PR I was not able to see a change D: EDIT: I figured out that this was my tree sitter plugin messing with the indentation! sorry for the false alarm... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt on fixing what #42 reports.
I'm not yet sure if this fully fixes the issue. I'll be testing it more on the following days and will report any issue I find.