Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ES6 module system #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claudiopro
Copy link
Contributor

This PR modifies tower-of-babel modules to use the ES6 module system. The only relevant hurdle was the use of a named import for babel-core, as it doesn't use export default.

In babel-processor.js:

var babel = require("babel-core");
//...
var transpile = q.fbind(function (contents, filename) {
    var transpiled = babel.transform(contents, {

Becomes:

import {transform} from "babel-core";
//...
var transpile = q.fbind(function (contents, filename) {
    var transpiled = transform(contents, {

@yosuke-furukawa
Copy link
Owner

@claudiopro
Thank you for contribution. I don't want to use ES6 modules currently.
Because ES6 module is on spec, but the loader is still in progress.
I like ES6 syntax, but I don't want to write ES6 code under discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants