Add support for FTP authentication #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, we have assumed that user authentication is only relevant for HTTP(S). But the urllib module used to support HTTP authentication also supports FTP authentication. HTTP authentication requires more steps than FTP to work, so let just skip HTTP-specific steps for FTP authentication. Signed-off-by: Jérémie Dautheribes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that "if the server requires authentication, user name and password may be specified in the URL". I expected this authentication mechanism to work with FTP, but it does not.
Looking at the code, I saw that all the logic was in place to easily support FTP authentication, so this PR adds support for FTP authentication.