Fix test with json rounding issues: #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses a possible confusion with JSONS processors trimming significant zero digits from the fractional part of floating numbers. It changes zeros to nonzeros in the fractional part, as a way to enforce the processors to keep the digits. Another possible solution is to keep the YAML as-is, and ensure the json shows the prices as 450.00 and 2392.00; ie to change the json part to be string-equal to the yaml part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a possible confusion in a test case where JSON processors can trim trailing zero digits from the fractional part of floating numbers. It changes zeros to nonzeros in the fractional part, as a way to enforce the processors to keep the digits.
The point is not to be in the place of ambiguity where the processors could reasonably be expected to trim digits.
Another possible solution is to keep the YAML as-is, and ensure the json shows the prices as 450.00 and 2392.00; ie to change the json part to be string-equal to the yaml part, but this will stil run some risk of digit-trimming.