move socket read error handling logic around a bit #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always
read
when epoll says there is an error waiting. Thenread
will dispatch toerror
to get handling suitable for the specific socket. ForTunnel
we avoid doing anything (logging or counting the error) for EMSGSIZE.I realized we are entirely ignoring write errors, so I made them feed the same mechanism.
@mitar is that along the lines of what you had in mind?