Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move socket read error handling logic around a bit #184

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

RalfJung
Copy link
Member

We always read when epoll says there is an error waiting. Then read will dispatch to error to get handling suitable for the specific socket. For Tunnel we avoid doing anything (logging or counting the error) for EMSGSIZE.

I realized we are entirely ignoring write errors, so I made them feed the same mechanism.

@mitar is that along the lines of what you had in mind?

@mitar
Copy link
Member

mitar commented Aug 16, 2023

Yea. This looks good.

@RalfJung RalfJung merged commit 9d9c49e into master Aug 16, 2023
5 checks passed
@RalfJung RalfJung deleted the error branch August 16, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants