-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clever Cloud deploy guide #9030
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Thanks for this submission, @juliamrch ! I'll wait until it's out of draft before having anyone look at it for a review! In the mean time, this PR appears to commit some changes to other files (VS Code settings, package.json). Can you make sure these don't end up in the final PR? Thanks! 🙌 |
Thanks for the feedback @sarah11918 I will make sure it doesn't include non-relevant files and mark it as ready next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @juliamrch. Thanks for the PR!
I've run through the guide for the first time, and provided some initial feedback. There were some things blocking me from completing the deployment, but I managed to eventually, and added some feedback on using different package managers, using preview over dev, etc.
Once these issues are resolved, I'll run through a second time to check everything works, and then review the wording.
If you need help with anything, please let me know!
<CardGrid> | ||
<LinkCard | ||
title="Node.js documentation" | ||
description="Clever Cloud documentation on Node.js applications." | ||
href="https://developers.clever-cloud.com/doc/applications/javascript/nodejs/" | ||
/> | ||
<LinkCard | ||
title="Static documentation" | ||
description="Clever Cloud documentation on Static applications." | ||
href="https://developers.clever-cloud.com/doc/applications/static/" | ||
/> | ||
</CardGrid> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<CardGrid> | |
<LinkCard | |
title="Node.js documentation" | |
description="Clever Cloud documentation on Node.js applications." | |
href="https://developers.clever-cloud.com/doc/applications/javascript/nodejs/" | |
/> | |
<LinkCard | |
title="Static documentation" | |
description="Clever Cloud documentation on Static applications." | |
href="https://developers.clever-cloud.com/doc/applications/static/" | |
/> | |
</CardGrid> | |
## Official Resources | |
- [Node.js documentation](https://developers.clever-cloud.com/doc/applications/javascript/nodejs/) | |
- [Static app documentation](https://developers.clever-cloud.com/doc/applications/static/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you want to remove the cards? They're so pretty 🥲
import ReadMore from '~/components/ReadMore.astro'; | ||
import { Steps } from '@astrojs/starlight/components'; | ||
import { CardGrid, LinkCard } from '@astrojs/starlight/components'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import ReadMore from '~/components/ReadMore.astro'; | |
import { Steps } from '@astrojs/starlight/components'; | |
import { CardGrid, LinkCard } from '@astrojs/starlight/components'; | |
import { Steps } from '@astrojs/starlight/components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem
Co-authored-by: Reuben Tier <[email protected]>
Co-authored-by: Reuben Tier <[email protected]>
Co-authored-by: Reuben Tier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some minor things that could be improved in this PR :)
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Thanks @casungo syntax senpaï |
Description (required)
This PR includes:
/src/guides/deploy
that directs to the guidePreview pages
Related issues & labels (optional)
We love Astro at Clever Cloud <3 and we have ran some tests to try its features. Hope this PR is clear enough, feel free to ask for clarifications or to point out errors in this doc if needed.