Updating logstash to v1 #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABH
reviewed
Mar 11, 2019
| logstash['@fields'] = info; | ||
| if (info.level) { | ||
| logstash.level = info.level; | ||
| delete info.level; |
There was a problem hiding this comment.
@tomasAlabes Thanks and sorry for slow review! Only question is: why are you deleting info.level? This doesn't seem necessary and feels like it could interfere with subsequent formatters that expect to find it? Let me know what you think -- thanks!
There was a problem hiding this comment.
No problem David.
Honestly, I was just following the pattern of the previous code 🤷♂️
|
Happy to merge once comments are addressed |
ad737079
reviewed
Aug 1, 2019
| @@ -23,7 +24,12 @@ module.exports = format(info => { | |||
| delete info.timestamp; | |||
| } | |||
|
|
|||
| logstash['@fields'] = info; | |||
There was a problem hiding this comment.
Removing this line will also remove all root level fields, not just level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from https://github.com/logstash/logstash-logback-encoder#standard-fields