Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update use of WebIDL "invoke a callback function" #1320

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jeremyroman
Copy link
Contributor

The only use which is not promise-returning is the "start" algorithm, which should rethrow the exception (so it can in turn be rethrown from the ReadableStream constructor.

Part of whatwg/webidl#1425.

  • At least two implementers are interested (and none opposed): n/a (no normative change)
  • Tests are written and can be reviewed and commented upon at: n/a (no normative change)
  • Implementation bugs are filed: n/a (no normative change)
  • MDN issue is filed: n/a (no normative change)
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

The only use which is not promise-returning is the "start" algorithm,
which should rethrow the exception (so it can in turn be rethrown from
the ReadableStream constructor.

Part of whatwg/webidl#1425.
Copy link
Collaborator

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ricea ricea merged commit 95a5adf into whatwg:main Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants