Support automatic user prompt handing in WebDriver BiDi #10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
reviewed
May 24, 2024
source
Outdated
| @@ -90720,22 +90720,28 @@ location.href = '#foo';</code></pre> | |||
| <p>then:</p> | |||
|
|
|||
| <ol> | |||
| <li><p>Set <var>unloadPromptShown</var> to true.</p></li> | |||
| <li> | |||
| <p>Let <var>userPromptHandler</var> be the result of | |||
There was a problem hiding this comment.
The formatting of this whole section is a bit off. Maybe you can fix that?
OrKoN
reviewed
Jun 11, 2024
jgraham
force-pushed
the
prompt_handler
branch
2 times, most recently
from
06090d4
to
bb7b60e
Compare
Well it does, on the assumption that none/accept/dismiss are the only available options. In that case "dismiss" is what happens when the return value is neither "none" nor "accept". I think for |
This reads the return value from the WebDriver BiDi user prompt opened algorithm and uses it to decide whether to show the prompt, or skip showing it but act as if it had been accepted or canceled. At present the prompt opened function can return three values: "none", which causes the prompt to be displayed, "accept", which acts as if the prompt was accepted, and "dismiss" which acts as if the prompt was rejected. The WebDriver side is responsible for ensuring that only valid responses are sent for each prompt type (e.g. for an alert there isn't a "dismiss" option).
|
@jgraham is that PR ready for a general review now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads the return value from the WebDriver BiDi user prompt opened algorithm and uses it to decide whether to show the prompt, or skip showing it but act as if it had been accepted or canceled.
At present the prompt opened function can return three values: "none", which causes the prompt to be displayed, "accept", which acts as if the prompt was accepted, and "dismiss" which acts as if the prompt was rejected. The WebDriver side is responsible for ensuring that only valid responses are sent for each prompt type (e.g. for an alert there isn't a "dismiss" option).
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/timers-and-user-prompts.html ( diff )