-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSM2-P Effluent Metrics w/o Flowsheet Constraints #1492
base: main
Are you sure you want to change the base?
Conversation
# for v in metadata.list_supported_properties(): | ||
# if metadata[v.name].method is not None: | ||
# if model.props[1].is_property_constructed(v.name): | ||
# raise PropertyAttributeError( | ||
# "Property {v_name} is an on-demand property, but was found " | ||
# "on the stateblock without being demanded".format(v_name=v.name) | ||
# ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment these out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test was written to check that the constraints for VSS, ISS, TSS, COD, etc. were only built on-demand, but I've changed them from constraints to expressions, so I don't think this test applies anymore. On that note, I don't think I need to be touching the effluent properties in the flowsheet anymore either.
Fixes/Resolves:
This PR is similar to #1489, but it does not attempt to implement the effluent violation constraints in the BSM2_P_extension flowsheet - this will be handled in a separate PR. The constraints related to the effluent metrics are derived from the work of Flores-Alsina (specifically perf_plant_ss.m).
Summary/Motivation:
Define the effluent metrics for the BSM2_P_extension flowsheet
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: