Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSM2-P Effluent Metrics w/o Flowsheet Constraints #1492

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

MarcusHolly
Copy link
Contributor

Fixes/Resolves:

This PR is similar to #1489, but it does not attempt to implement the effluent violation constraints in the BSM2_P_extension flowsheet - this will be handled in a separate PR. The constraints related to the effluent metrics are derived from the work of Flores-Alsina (specifically perf_plant_ss.m).

Summary/Motivation:

Define the effluent metrics for the BSM2_P_extension flowsheet

Changes proposed in this PR:

  • Adds effluent metrics to the modified ASM2d property package
  • Updates the BSM2 GUI flowsheet images
  • Updates unit model tests affected by the changes made to the modified ASM2d prop pack

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Comment on lines +267 to +273
# for v in metadata.list_supported_properties():
# if metadata[v.name].method is not None:
# if model.props[1].is_property_constructed(v.name):
# raise PropertyAttributeError(
# "Property {v_name} is an on-demand property, but was found "
# "on the stateblock without being demanded".format(v_name=v.name)
# )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment these out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test was written to check that the constraints for VSS, ISS, TSS, COD, etc. were only built on-demand, but I've changed them from constraints to expressions, so I don't think this test applies anymore. On that note, I don't think I need to be touching the effluent properties in the flowsheet anymore either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants