Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA runner and Python versions #1483

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Aug 20, 2024

Summary/Motivation

  • Match Python versions currently supported by IDAES (3.9 through 3.12)
  • Update GHA runner versions to more recent ones (e.g. ubuntu-2004 -> ubuntu-2204)
  • Add macos jobs using macos-14 runners with Apple Silicon
  • Remove "experimental" macOS job using non-IDAES solvers

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl changed the title Gha runners revamp Update GHA runner and Python versions Aug 20, 2024
@lbianchi-lbl lbianchi-lbl marked this pull request as draft August 22, 2024 19:43
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 22, 2024
@ksbeattie ksbeattie self-requested a review August 22, 2024 20:18
@ksbeattie ksbeattie added Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Aug 22, 2024
@lbianchi-lbl
Copy link
Contributor Author

  • As @bknueven points out, Python 3.12 has a non-backward-compatible change in the built-in Python sum() function that might be causing the Python 3.12 jobs to fail consistently across platforms
  • macOS (with the new Apple Silicon runners) seems to be failing consistently across all Python versions. Most if not all failures come from the BSM2 model

@ksbeattie
Copy link
Contributor

Waiting for #1469

@bknueven
Copy link
Contributor

Let's fix the easy things to fix and mark the remainder as xfail and return to them after the next release.

@bknueven
Copy link
Contributor

@lbianchi-lbl I believe I got all the "false positives" in the PR which are easy to fix. I would suggest we mark the remaining as x-fail strict. The remaining models which do not pass are under active development / tweaking, so we should know if they start passing due to some change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants