Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer tools contexts in runtime.getContexts() proposal #675

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Add developer tools contexts in runtime.getContexts() proposal #675

merged 4 commits into from
Sep 13, 2024

Conversation

sohailrajdev97
Copy link

Proposal for #670.

@sohailrajdev97 sohailrajdev97 requested review from rdcronin, oliverdunk and Rob--W and removed request for rdcronin August 19, 2024 11:41
oliverdunk
oliverdunk reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sohail, this generally looks good to me! I'll chat to the team before adding an approval.

proposals/runtime_get_contexts.md Outdated Show resolved Hide resolved
proposals/runtime_get_contexts.md Outdated Show resolved Hide resolved
rdcronin
rdcronin reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@rdcronin rdcronin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sohail! This looks pretty good. Same question as Oliver, but overall, no concerns.

proposals/runtime_get_contexts.md Outdated Show resolved Hide resolved
@dotproto dotproto mentioned this pull request Aug 29, 2024
Closed
@Rob--W Rob--W mentioned this pull request Aug 29, 2024
Merged
@Rob--W Rob--W mentioned this pull request Sep 12, 2024
Merged
oliverdunk
oliverdunk approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and matches the behavior implemented in Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/5849634

Thanks for the work on this!

@oliverdunk oliverdunk merged commit afe9be4 into w3c:main Sep 13, 2024
3 checks passed
github-actions bot added a commit that referenced this pull request Sep 13, 2024
@oliverdunk @github-actions
Merge pull request #675 from sohailrajdev97/developer-tools-contexts
fd94656 
SHA: afe9be4
Reason: push, by oliverdunk

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Sep 13, 2024
@oliverdunk @github-actions
Merge pull request #675 from sohailrajdev97/developer-tools-contexts
02f9294 
SHA: afe9be4
Reason: push, by oliverdunk

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosjeurissen carlosjeurissen carlosjeurissen left review comments

@xeenon xeenon xeenon approved these changes

@Rob--W Rob--W Rob--W approved these changes

@oliverdunk oliverdunk oliverdunk approved these changes

@rdcronin rdcronin Awaiting requested review from rdcronin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sohailrajdev97 @xeenon @carlosjeurissen @Rob--W @rdcronin @oliverdunk