Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish minutes of 2022-09-15 meeting #275

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Publish minutes of 2022-09-15 meeting #275

merged 1 commit into from
Sep 15, 2022

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Sep 15, 2022

Generated from https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit using the tool and process from #105.

During this meeting we discussed or mentioned #258, #269, #270, #271, #259, #272, #162, #232.

I also added a link to the previous meeting notes in the TOC, because I forgot to include those in #268.


[Issue 258](https://github.com/w3c/webextensions/issues/258): Per-extension language preferences

* [carlos] (summarizes issue and recent comment at https://github.com/w3c/webextensions/issues/258#issuecomment-1248028674)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of the issue is here #258 , not that comment. I reorganized the proposal on 2022-09-12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the meeting, I have explained your issue in detail. Explained the fact you drew inspiration from the handling on Android, how there are use cases to have an app / extension in a different language than the OS / browser. And the proposed methods / solutions proposed by you (@hanguokai).

Only later after comments from Rob and Simeon, I have explained some points made in my comment. This happened in between:
[timothy] It would also leak to the browser UI (button labels etc).
[simeon] What is “create instance” in i18n.createLanguageInstance referring to?

Between those comments, @xeenon was asking for the getMessage syntax he found in this issue before. On which I mentioned the fact the original post first mentioned the getMessage-extension and was later extended / modified by you (@hanguokai) to include the other proposals (setCurrentLanguage, getCurrentLanguage, and so on). After which I mentioned the alternative syntax as is now described in #274.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosjeurissen Sorry, I didn't attend this meeting. And thanks for the explanation.

@Rob--W
Copy link
Member Author

Rob--W commented Sep 15, 2022

Merging to make it easier to create the meeting notes for the second meeting of the day.

@Rob--W Rob--W merged commit 503586a into main Sep 15, 2022
@Rob--W Rob--W deleted the meeting-2022-09-15 branch September 15, 2022 22:42
github-actions bot added a commit that referenced this pull request Sep 15, 2022
SHA: 503586a
Reason: push, by @Rob--W

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants