Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix todomvc example: prefix todomvc mounted hook with "vue:" #241

Closed
wants to merge 1 commit into from

Conversation

ethmcc
Copy link

@ethmcc ethmcc commented Aug 31, 2024

The todomvc example has a use of the @mounted hook, triggering an error:

mounted and unmounted hooks now need to be prefixed with vue: - use @vue:mounted="handler" instead.

I checked for any other stray uses of @mounted or @unmounted in the repo to clean up; there were no other instances.

Fixes error: 

mounted and unmounted hooks now need to be prefixed with vue: - use @VUE:mounted="handler" instead.
@ethmcc
Copy link
Author

ethmcc commented Aug 31, 2024

Closing because I looked through the open PRs and noticed that fixes for this and other examples were already proposed in: #224.

Looks like this bug first noted in #170, over two years ago, but nothing has been merged since months before that.

@ethmcc ethmcc closed this Aug 31, 2024
@jikkuatwork
Copy link

Thats sad! Wish the relevant fixes were addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants