Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support template props omitted #265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yangxiuxiu1115
Copy link
Contributor

@yangxiuxiu1115 yangxiuxiu1115 commented Aug 1, 2024

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit c7f1222
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/66acd252d1fddb000842ebe9
😎 Deploy Preview https://deploy-preview-265--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit c7f1222
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/66acd2528182b00008bfcbbe
😎 Deploy Preview https://deploy-preview-265--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 1, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.5 kB 28.3 kB 24.9 kB
compiler-vapor.global.prod.js 56.9 kB (+8 B) 19.4 kB (+5 B) 17.6 kB (+33 B)
runtime-dom.global.prod.js 94.7 kB 36 kB 32.4 kB
runtime-vapor.global.prod.js 48 kB (+2 B) 18.1 kB (+1 B) 16.6 kB (-34 B)
vue-vapor.global.prod.js 102 kB (+10 B) 36 kB (+6 B) 32.4 kB (+28 B)
vue.global.prod.js 152 kB 55.8 kB 49.6 kB

Usages

Name Size Gzip Brotli
createApp 54.4 kB 21 kB 19.2 kB
createSSRApp 57.9 kB 22.4 kB 20.4 kB
defineCustomElement 56.6 kB 21.7 kB 19.8 kB
vapor 48.6 kB (+2 B) 18.3 kB (+1 B) 16.7 kB (+1 B)
overall 67.9 kB 26 kB 23.6 kB

Copy link

pkg-pr-new bot commented Aug 1, 2024

commit: c7f1222

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-core@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-dom@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-sfc@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-ssr@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-vapor@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/reactivity@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-core@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-dom@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-shared@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-vapor@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/server-renderer@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/shared@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/vue@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compat@265
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/vapor@265

Open in Stackblitzplayground

Copy link
Member

@LittleSound LittleSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding this PR, here are some of my thoughts:

  1. If props are not needed, maybe you can skip generating them.
  2. Follow the existing definition and change _props to $props.

Also, I tried it in the Playground, and it doesn't seem to work properly.

@yangxiuxiu1115
Copy link
Contributor Author

oh,Looks like I'm missing a part of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants