Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-3861 - add generic client wrapper #57

Closed
wants to merge 2 commits into from
Closed

RSDK-3861 - add generic client wrapper #57

wants to merge 2 commits into from

Conversation

clintpurser
Copy link
Member

add a client wrapper for the generic component

@clintpurser clintpurser requested a review from njooma July 3, 2023 14:23
@clintpurser clintpurser requested a review from a team as a code owner July 3, 2023 14:23
@clintpurser clintpurser requested a review from stuqdog July 3, 2023 14:23
@clintpurser
Copy link
Member Author

this ended up not being needed for the demo app i am working on. but its done, so might as well carry on and merge it. 🤷

njooma
njooma requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some tests plz?

@clintpurser
Copy link
Member Author

closing because this isn't a priority right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma requested changes

@stuqdog stuqdog stuqdog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clintpurser @njooma @stuqdog