Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge-merge-mode property #153

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

tokkoro
Copy link
Contributor

@tokkoro tokkoro commented Aug 2, 2024

Build on #142

This PR will add edge-merge-mode setting to pipeline nodes. The actual handling of it is a responsibility for the system handling the edge.

The options are to have the new files from edge be appended to input or for them to replace whatever was in the template.

@tokkoro tokkoro force-pushed the tokkoro/feat/add-edge-merge-mode branch from c8fc725 to 4135c74 Compare August 22, 2024 08:59
@tokkoro tokkoro marked this pull request as ready for review August 29, 2024 11:33
@tokkoro tokkoro requested review from akx, hylje, teroyks and memona008 and removed request for akx and hylje August 29, 2024 11:33
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and understandable!

@akx akx changed the title Add edge-merge-mode property in Input Add edge-merge-mode property Aug 30, 2024
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akx akx merged commit a74692c into master Aug 30, 2024
6 checks passed
@akx akx deleted the tokkoro/feat/add-edge-merge-mode branch August 30, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants