Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task parameter-sets #135

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add Task parameter-sets #135

merged 1 commit into from
Nov 2, 2023

Conversation

akx
Copy link
Member

@akx akx commented Nov 1, 2023

Fixes #134

@akx akx requested review from a team, hylje, ruksi and memona008 and removed request for a team November 1, 2023 14:04
@akx akx force-pushed the manual-search-parameter-sets branch from 47c256e to c33bde7 Compare November 1, 2023 14:05
@akx akx requested review from tokkoro and removed request for memona008 November 1, 2023 14:05
Copy link
Contributor

@hylje hylje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example, test, parsing

Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

could lint that the parameters in parameter sets actually exist

but then again, we could have future use for some arbitrary values in parameter sets 🤔

@akx akx force-pushed the manual-search-parameter-sets branch from c33bde7 to 48a12a4 Compare November 2, 2023 13:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #135 (48a12a4) into master (fba4319) will decrease coverage by 0.07%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   92.12%   92.05%   -0.07%     
==========================================
  Files          65       65              
  Lines        2069     2076       +7     
  Branches      351      353       +2     
==========================================
+ Hits         1906     1911       +5     
- Misses         80       81       +1     
- Partials       83       84       +1     
Files Coverage Δ
tests/test_task.py 95.83% <100.00%> (+0.59%) ⬆️
valohai_yaml/objs/task.py 89.18% <50.00%> (-2.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akx akx merged commit 31cac78 into master Nov 2, 2023
6 checks passed
@akx akx deleted the manual-search-parameter-sets branch November 2, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task presets: allow configuring parameter sets for Manual Search
4 participants