Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: add remaining fields (maximum queued executions, on child error) #132

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Task: add remaining fields (maximum queued executions, on child error) #132

merged 1 commit into from
Oct 30, 2023

Conversation

akx
Copy link
Member

@akx akx commented Oct 30, 2023

Fixes #90

@akx akx requested review from a team, ruksi, axelauvinen and memona008 and removed request for a team October 30, 2023 13:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #132 (f888f7c) into master (27bb15e) will decrease coverage by 0.03%.
The diff coverage is 89.47%.

❗ Current head f888f7c differs from pull request most recent head 7acc94a. Consider uploading reports for the commit 7acc94a to get more accurate results

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   92.28%   92.25%   -0.03%     
==========================================
  Files          64       64              
  Lines        2049     2067      +18     
  Branches      346      349       +3     
==========================================
+ Hits         1891     1907      +16     
- Misses         77       78       +1     
- Partials       81       82       +1
Files Coverage Δ
tests/test_task.py 95.23% <100.00%> (+0.50%) ⬆️
valohai_yaml/objs/task.py 91.42% <87.50%> (-1.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

axelauvinen
axelauvinen previously approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@axelauvinen axelauvinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, opinionated example botherment

examples/task-example.yaml Outdated Show resolved Hide resolved
@akx akx requested a review from axelauvinen October 30, 2023 13:37
axelauvinen
axelauvinen approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@axelauvinen axelauvinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@akx akx merged commit a50d0ec into master Oct 30, 2023
6 checks passed
@akx akx deleted the task-rest branch October 30, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelauvinen axelauvinen axelauvinen approved these changes

@ruksi ruksi Awaiting requested review from ruksi ruksi was automatically assigned from valohai/dev

@memona008 memona008 Awaiting requested review from memona008 memona008 was automatically assigned from valohai/dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define maximum queued executions for Task
3 participants
@akx @codecov-commenter @axelauvinen