-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task-presets to serializer to expose via commit with config #128
Conversation
eae7456
to
3a899ae
Compare
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 92.32% 92.33% +0.01%
==========================================
Files 63 63
Lines 2032 2035 +3
Branches 340 341 +1
==========================================
+ Hits 1876 1879 +3
Misses 76 76
Partials 80 80
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e8c6571
to
bda20e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commits are wrong away around so the first commit tests will fail
but I'll refrain myself from the actual approval as I proposed the solution ♻️
bda20e6
to
ce5470a
Compare
ce5470a
to
15e5eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
relates: https://github.com/valohai/roi/issues/5200
Exposing task presets from YAML to API via config serializer