Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task-presets to serializer to expose via commit with config #128

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

axelauvinen
Copy link
Contributor

@axelauvinen axelauvinen commented Oct 17, 2023

relates: https://github.com/valohai/roi/issues/5200

Exposing task presets from YAML to API via config serializer

@axelauvinen axelauvinen force-pushed the axel/feat/expose-task-presets branch 2 times, most recently from eae7456 to 3a899ae Compare October 17, 2023 12:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #128 (ce5470a) into master (8f03eae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   92.32%   92.33%   +0.01%     
==========================================
  Files          63       63              
  Lines        2032     2035       +3     
  Branches      340      341       +1     
==========================================
+ Hits         1876     1879       +3     
  Misses         76       76              
  Partials       80       80              
Files Coverage Δ
valohai_yaml/objs/config.py 97.14% <ø> (ø)
valohai_yaml/objs/utils.py 80.85% <100.00%> (+1.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@axelauvinen axelauvinen marked this pull request as ready for review October 30, 2023 08:14
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commits are wrong away around so the first commit tests will fail

but I'll refrain myself from the actual approval as I proposed the solution ♻️

valohai_yaml/objs/utils.py Outdated Show resolved Hide resolved
@akx akx disabled auto-merge October 30, 2023 10:56
@akx akx enabled auto-merge (squash) October 30, 2023 10:56
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@akx akx merged commit 921632d into master Oct 30, 2023
6 checks passed
@akx akx deleted the axel/feat/expose-task-presets branch October 30, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants