Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 64-bit installer #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add 64-bit installer #7

wants to merge 2 commits into from

Conversation

digitalcoyote
Copy link

Adds 64-bit installer for #6

Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, please fix the indentation and checksumType, thank you.

transgui/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
transgui/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
url64bit = 'https://github.com/transmission-remote-gui/transgui/releases/download/v5.18.0/transgui-5.18.0-setup_64bit.exe'
checksum = '07CC99294C83D2AE429033ABBDB99642F5271984966616FB2C319F087448C936'
checksum64 = 'BC625C3E32979FDDC9F30FB352843AD0AF2537F331ADDD59DD819381DF07B425'
checksumType = 'sha512'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the checksumType shouldn't be changed here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended with correction. And yeah I must have changed the checksum type out of habit. I should have double-checked this better before submitting a PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to send another PR after this one 👍

transgui/tools/chocolateyInstall.ps1 Show resolved Hide resolved
transgui/update.ps1 Outdated Show resolved Hide resolved
@PeterDaveHello PeterDaveHello changed the title Added 64-bit installer Add 64-bit installer Oct 29, 2019
Comment on lines -22 to +30
$url = $download_page.links | ? href -match $re | select -Expand href -First 1 | % { 'https://github.com' + $_ }
$version = (Split-Path $url -Parent).Split("v")[1]
$url32 = $download_page.links | ? href -match $re | select -Expand href -First 1 | % { 'https://github.com' + $_ }
$version = (Split-Path $url32 -Parent).Split("v")[1]
$url64 = "https://github.com/transmission-remote-gui/transgui/releases/download/v$version/transgui-$version-setup_64bit.exe"

@{
Version = $version
URL32 = $url
URL32 = $url32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate change url -> url32 to another PR or another commit to keep the 64bit installer introduce minimized and focus on only 64bit related changes?

The other parts look good to me 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, can leave it as $url. It's somewhat of a grey area in packages I've seen as to whether or not the 32-bit url is specified as 32. Chocolatey's API seems to use -URL and -URL64(Bit) more than URL32

Copy link
Author

@digitalcoyote digitalcoyote Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed an amend with that change removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to use "32" as part of the keyword, but just separately ;)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you prefer the variable naming, I'll add a second commit with it.

@@ -20,12 +22,15 @@ function global:au_GetLatest {
$download_page = Invoke-WebRequest -Uri $releases -UseBasicParsing
$re = '\.exe$'
$url = $download_page.links | ? href -match $re | select -Expand href -First 1 | % { 'https://github.com' + $_ }
$version = (Split-Path $url -Parent).Split("v")[1]
$version = (Split-Path $url32 -Parent).Split("v")[1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable is missed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ Amending. I think I normally rely too much on the compiler to catch mistakes of that nature.

@PeterDaveHello
Copy link
Member

LGTM 👍 @mom1 what do you think?

@PeterDaveHello
Copy link
Member

If there isn't any rejection, I'll merge this once our 64bit release issue was fixed, thanks for the works here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants