Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize some PHP syntax #757

Merged
merged 4 commits into from
Jul 21, 2024
Merged

Modernize some PHP syntax #757

merged 4 commits into from
Jul 21, 2024

Conversation

bakerkretzmar
Copy link
Collaborator

This PR is a light refactor to spruce up some of Ziggy's code a bit.

  • Uses constructor property promotion, first class callable syntax, more short arrow functions, and more readable Heredoc indentation.
  • Removes existence checks for Laravel functionality that is now in all versions of Laravel that we support, like the Illuminate\Support\Reflector class and the URL generator getDefaultParameters and Route bindingFields methods.
  • Inlines some code that was in methods that were only being called in one place.

@bakerkretzmar bakerkretzmar merged commit 026671f into 2.x Jul 21, 2024
22 checks passed
@bakerkretzmar bakerkretzmar deleted the syntax-81 branch July 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bakerkretzmar