Pest #756
Merged
Pest #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run tests using Pest and test on PHP 8.4
…ift` and fix errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs Pest and converts the whole PHP test suite to use it, reduces boilerplate and noise in the test suite, and adds test runs on PHP 8.4.
Having to downgrade Pest to v1 and reinstall PHPUnit for the Laravel 9 testing workflows is kind of a bummer but it works, and we're not using anything specific to Pest v2.
I only removed a couple tests that were redundant and testing code covered by other tests already.
Over time we may even be able to clean this up a lot more by making heavier use of data providers.