feat: Support for lambda code signing #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xisting s3 package
* Update lambda module to 6.5.0 and add variable for code signing and existing s3 package * Update README.md * Update condition for source_path when null and s3_existing_package is set * Add example for signed code
hazmei
changed the title
Chore: Update readme
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
lambda_handlerlocal variable.source_pathinput for module lambda.Ensure that
source_pathis null whens3_existing_packageis set andlambda_source_pathis null. Previously this is set to./functions/notify_slack.pyiflambda_source_pathis not set.code_signing_config_arnin module lambda.Needed to attach the code signing config to the lambda.
lambda_code_signing_config_arn,custom_lambda_source_name,s3_existing_package.terraform-aws-modules/lambda/awsto version 6.5.0 forcode_signing_config_arn.Motivation and Context
We have a requirement to secure the lambdas provisioned in our AWS account with code signing. This introduce support for deploying this module with lambda code signing enforced.
Breaking Changes
No breaking of backwards compatibility.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request