Editorial: Rename aliases in Canonicalize for better readability #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
commented
Sep 3, 2024
| 1. Return _cu_. | ||
| 1. Let _mapped_ be toUppercase(« _cp_ »), according to the Unicode Default Case Conversion algorithm. | ||
| 1. If the length of _mapped_ ≠ 1 or the length of CodePointsToString(_mapped_) ≠ 1, return _ch_. | ||
| 1. Let _mappedCP_ be the single code point element of _mapped_. |
There was a problem hiding this comment.
This step could be followed by an assertion, but I have a slight preference for omitting it.
Suggested change
| 1. Let _mappedCP_ be the single code point element of _mapped_. | |
| 1. Let _mappedCP_ be the single code point element of _mapped_. | |
| 1. Assert: _mappedCP_ ≤ 0xFFFF. |
There was a problem hiding this comment.
Same, I don't think it's helpful.
gibson042
force-pushed
the
2024-09-regexp-canonicalize-alias-names
branch
from
73d671d
to
21057df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.