Editorial: add missing note for Annex B replacement #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Looks okay to me. Mind you, PR #2952 obviates it (because every inlined patch has a link to the relevant Annex B section anyway).
Outside of Annex B replacements, there's also the one in Number::toString. The Note that describes the replacement appears after the algorithm, but there isn't a Note right at the step in question. Maybe less important because it's only a recommendation, not a requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a note that references back to every Annex B replacement we make, except for this one. Discovered while trying to make such a claim in a live presentation today 😩. Also fixes up one of the back-references to be in a note.