Taxes.ts update #34
Open
Taxes.ts update #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix formatting in README
Update deps
Update deps, improve linting, fix type errors
Update deps & bump version
Update deps, enable next.js turbo dev mode, update header & footer, fix FX issue, update GitHub workflow versions
Update deps
Update deps
deductibleExpenses already substracted from income on line 53 so there is no need to substract it again on line 71. This will lead to a wrong taxableIncome value. Discovered this when calculating my taxes and obtaining different values on this calculator when comparing to some other calculators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to taxes.ts. Discovered that deductibleExpanses is substracted twice from the income so I am proposing this change