Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A function for single request forwarding #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

timur-han
Copy link

A new function for forwarding single requests.

@AeroNotix
Copy link

The code as-is looks good.

However, the code just exists in a vacuum. Could you describe what you're using it for?

@alandipert
Copy link
Member

It looks nearly identical to the body of wrap-proxy - perhaps we could replace the guts of a wrap-proxy, which is already kinda big, with a call to this function?

@timur-han
Copy link
Author

To forward selective requests.

For instance only to forward a request on certain a path and under a
certain condition.

On Thu, Oct 16, 2014 at 3:21 PM, Aaron France [email protected]
wrote:

The code as-is looks good.

However, the code just exists in a vacuum. Could you describe what you're
using it for?


Reply to this email directly or view it on GitHub
#10 (comment)
.

@AeroNotix
Copy link

@timur87 As @alandipert could you refactor it so that it shares implementation with wrap-proxy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants