fix(circuit-ui): ColorInput paste and change events #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8364e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
==========================================
+ Coverage 86.63% 86.73% +0.10%
==========================================
Files 210 210
Lines 12000 12036 +36
Branches 1506 1515 +9
==========================================
+ Hits 10396 10440 +44
+ Misses 1551 1543 -8
Partials 53 53
|
matoous
force-pushed
the
md/color-input-fixups
branch
from
08457d2
to
cbe2b7f
Compare
Improve ColorInput, specifically: - handle default value and value props properly - ensure color picker and hex color input are always synchronized - handle properly paste events with hex color
matoous
force-pushed
the
md/color-input-fixups
branch
from
cbe2b7f
to
16ceaee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ColorInput, specifically: