Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(typing): added generic support and imporved return type for useAsyncStoryblok #833

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gbyesiltas
Copy link

@gbyesiltas gbyesiltas commented May 8, 2024

Changes list

  • Improved the return type to not be Promise<any> anymore
  • Users can now specify the type of the SB Component they are fetching while using useAsyncStoryblok using a generic
  • Updated examples and readme

before vs after (without even passing any generic types):
Screenshot 2024-05-08 at 12 06 19

Screenshot 2024-05-08 at 12 10 17

relates to: #543

@AdrianFahrbach
Copy link

@alvarosabu Any chance to get this merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants