fix(common): clean up types #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
commented
Jul 24, 2024
Comment on lines
+10
to
+21
| interface AppConfigInput { | ||
| type: PluginType; | ||
| appBridge?: AppBridgeConfig; | ||
| auth?: AuthConfig; | ||
| } | ||
|
|
||
| interface AppConfig { | ||
| type: PluginType; | ||
| appBridge: AppBridgeConfig; | ||
| auth: AuthConfig; | ||
| } | ||
| } |
There was a problem hiding this comment.
I've discovered that we can have different AppConfigInput and AppConfig (output):
https://nuxt.com/docs/guide/directory-structure/app-config#typing-app-config
So we can have appBridge and auth being optional, but in the end, Nuxt will merge all the app configs from the layers, and provide the complete version of AppConfig.
There was a problem hiding this comment.
that makes sense maybe adding a comment would help us understand this better in future? WDYT?
Comment on lines
7
to
8
| }, | ||
| auth: { | ||
| endpointPrefix: '/api/connect', | ||
| initOauthFlowUrl: `/api/connect/storyblok`, | ||
| successCallback: '/', | ||
| errorCallback: '/401', | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Now we no longer need to have full appConfig. Only things that we want to override.
BibiSebi
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR does several things:
AppConfigpatch toindex.d.ts, so that all the projects that use nuxt-base will have the same type../typesto be auto-imported