fix(space-nuxt-base): move plugin type to the top level of app config #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
force-pushed
the
fix/refactor-app-bridge
branch
from
c2f11f1
to
34e4b26
Compare
eunjae-lee
force-pushed
the
fix/move-plugin-type
branch
from
10d3378
to
df3ebc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves the plugin type to the top level of appConfig.
Why?
This way, we can differentiate if the project is a tool plugin or a space plugin no matter if it's using app bridge or not. It's not necessary right now, but with this, we could easily create a starter for Tool Plugins based on this nuxt-base project. Only difference between Space Plugins and Tool Plugins is that Tool Plugins should send its height to Storyfront. We can do it by updating the layout file within Tool Plugins' starter project.